Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Tests #16

Open
harens opened this issue Nov 29, 2020 · 2 comments
Open

Additional Tests #16

harens opened this issue Nov 29, 2020 · 2 comments
Labels
codebase Issues relating to the source code good first issue Good for newcomers tests Issues relating to testing the source code

Comments

@harens
Copy link
Owner

harens commented Nov 29, 2020

Having more tests can never be a bad thing!

Tests can be found in the tests.py file. An example would be the following:

test(isbn.missing("?131103628"), "0")

The first parameter of test is the function to be tested, and the second is the expected value.

EDIT: This issue will be an ongoing issue, since when new features are added, more tests will be required.

@harens harens added good first issue Good for newcomers codebase Issues relating to the source code tests Issues relating to testing the source code labels Nov 29, 2020
@Paty-Alonso
Copy link

Hello @harens! I'm interested in working on this issue

@harens
Copy link
Owner Author

harens commented Dec 3, 2020

Hi @Paty-Alonso 👋 Thanks for your interest in this issue!

Any tests that you think would help are more than welcome. Until #15 is sorted (at least to some extent), I'd prefer if the inputs had a standard format (i.e. not random letters and characters for now), but I'll leave that to your judgement.

There are loads of resources available if anything's unclear, including the Setup Section, the Wiki, and the docstring in tests.py. If you find any tests that you expect to work but don't, feel free to file an issue.

If you need any help, let me know. Thanks for your assistance, I really appreciate it 👍.

harens added a commit that referenced this issue May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase Issues relating to the source code good first issue Good for newcomers tests Issues relating to testing the source code
Projects
None yet
Development

No branches or pull requests

2 participants