Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GS1 capability #38

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Add GS1 capability #38

merged 3 commits into from
Apr 27, 2021

Conversation

OtherBarry
Copy link
Contributor

I wanted to use this library for a project, but having to replace the "X" in isbn was annoying, and there was no way to handle GS1 codes other than GTIN-13

I've written tests for GTIN-8, GTIN-12, GTIN-13, GTIN-14, GSIN and SSCC, using the check digit calculator on the GS1 site.

Let me know if there's anything else that needs to be done to get this merged.

@harens
Copy link
Owner

harens commented Apr 27, 2021

Wow! Thanks so much @OtherBarry for this PR, it looks amazing 🎉 (and matches the style of the other files eerily well). I'll run the tests, and assuming they pass, I'm more than happy to merge this.

I wanted to use this library for a project, but having to replace the "X" in isbn was annoying

Thank you for using this project. I'll push a minor release with your work so that you can use this.

Copy link
Owner

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OtherBarry for your PR! 👍

I'll publish a new release sometime today. Now that I know other people are using this project, I'll try and spend some more time refactoring and adding new features.

Thanks again for your pull request! 🍾

@harens harens merged commit 7be0af0 into harens:master Apr 27, 2021
@harens
Copy link
Owner

harens commented May 15, 2021

Thanks again for your amazing work @OtherBarry! @all-contributors please add @OtherBarry for code. 🎉

@allcontributors
Copy link
Contributor

@harens

I've put up a pull request to add @OtherBarry! 🎉

@harens
Copy link
Owner

harens commented May 15, 2021

Actually, as well as that, @all-contributors please add @OtherBarry for test.

@allcontributors
Copy link
Contributor

@harens

I've put up a pull request to add @OtherBarry! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants