Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hide_results_on_select option #2687

Merged
merged 1 commit into from
Sep 14, 2016
Merged

add hide_results_on_select option #2687

merged 1 commit into from
Sep 14, 2016

Conversation

koenpunt
Copy link
Collaborator

hide_results_on_select will default to true, to keep it backwards compatible.

the change is quite trivial, but the demand for it is high, so we might consider adding this?

cc: @pfiller @tjschuck @stof

fixes #1546

hide_results_on_select will default to true, to keep it backwards
compatible.

fixes #1546
@tjschuck
Copy link
Member

Seems okay to me 👍

Up to you if you want a better 👍 than mine 😜

@koenpunt koenpunt merged commit 81c1725 into master Sep 14, 2016
@koenpunt koenpunt deleted the hide_results_on_select branch September 14, 2016 15:39
@koenpunt
Copy link
Collaborator Author

I've drafted a release as 1.7.0 (minor b/c new feature). Are you aware of other fixes that we could include in this release? Or should we just release it?

@boynet
Copy link

boynet commented Feb 22, 2017

+1 for release it

@koenpunt
Copy link
Collaborator Author

1.7.0 has just been released

@deterset
Copy link

deterset commented Dec 6, 2017

I like hide_results_on_select option but it always scrolls back to the top and I always have to find my place near the bottom or middle again. Is there any way to keep where you are so you can easily pick all the options you need ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stay open on multi select
4 participants