Remove deprecation warnings on jQuery 3 #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests will now run on both jquery 3 (currently maintained version) and 1.12 (to ensure we don't break compat with it).
This bumps the min jQuery version to 1.7 rather than 1.6
davidcochrum
approved these changes
Aug 14, 2017
|
@satchmorun @adunkman If one of you 👍's this, I'm fine merging it on @stof's behalf. |
|
@stof This seems to have broken CI on master when merged: https://travis-ci.org/harvesthq/chosen/builds/267382751 |
|
Easy fix: #2869. |
|
Thanks @adunkman! ❤️ ❤️ 😻 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit makes our CI compatible with jQuery 3 (removing usage of the deprecated
.size()method in tests).The second commit removes usage of deprecated APIs of jQuery 3 (our code technically works on jQuery 3 without that, but triggers deprecation warnings when using jquery.migrate, which make it painful for our users trying to migrate away from deprecated APIs). Using
on()instead ofbindbumps the minimum version of jquery to 1.7. But this is OK IMO, as only jQuery 3 is still maintained nowadays, and jQuery 1.7 was released in 2014.Closes #2729