Escape optgroup label when appending to HTML. #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Sorry my bad english) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
Hot on the tails of the 1.8.1 release (and as a follow-up to #2879), this PR fixes a cross-site scripting vulnerability discovered when applying the 1.8.1 release to Harvest.
When an optgroup’s label is not highlighted, we’re using the unescaped version of the
labelattribute — but we’re safe when the highlighting is added, since we’re escaping each HTML fragment when building the highlighted string.Included is a test which asserts HTML tags are not rendered into HTML unescaped in this case.