-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wagmi example usage with Hedera #3000
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, minor suggestions.
Also images or short video are great attachments to the PR to should the UI representation of the code since it can't be seen by just reviewing the code
@@ -0,0 +1,21 @@ | |||
# Wagmi Hedera Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should add a brief summary on what Wagmi is an add a link.
For some developers this may be their first exposure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nana-EC will this summary be enough? https://github.com/hashgraph/hedera-json-rpc-relay/pull/3000/files#diff-bd7c3891dc764da67cba302d66c3bb940bc8d0851095de79357802669a2c2727R3 I've included the link as well.
tools/wagmi-example/src/App.tsx
Outdated
* | ||
* Hedera JSON RPC Relay - Wagmi Example | ||
* | ||
* Copyright (C) 2022-2024 Hedera Hashgraph, LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new files should be fine with just the current year I believe.
* Copyright (C) 2022-2024 Hedera Hashgraph, LLC | |
* Copyright (C) 2024 Hedera Hashgraph, LLC |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
8334732
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
===========================================
+ Coverage 77.06% 89.92% +12.85%
===========================================
Files 40 58 +18
Lines 3266 3900 +634
Branches 683 780 +97
===========================================
+ Hits 2517 3507 +990
+ Misses 529 346 -183
+ Partials 220 47 -173
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Description:
Validate wagmi support and add example usage with hedera
Related issue(s):
Implements: #2802
Checklist