Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wagmi example usage with Hedera #3000

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arianejasuwienas
Copy link
Contributor

Description:
Validate wagmi support and add example usage with hedera

Related issue(s):

Implements: #2802

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
@arianejasuwienas arianejasuwienas added the ArianeLabs Items ArianeLabs is contributing to label Sep 17, 2024
@arianejasuwienas arianejasuwienas added this to the 0.57.0 milestone Sep 17, 2024
@arianejasuwienas arianejasuwienas self-assigned this Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@arianejasuwienas arianejasuwienas added the enhancement New feature or request label Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

Acceptance Tests

  17 files  233 suites   29m 42s ⏱️
605 tests 599 ✔️ 4 💤 2
695 runs  687 ✔️ 6 💤 2

Results for commit 8334732.

♻️ This comment has been updated with latest results.

acuarica
acuarica previously approved these changes Sep 17, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

victor-yanev
victor-yanev previously approved these changes Sep 17, 2024
Copy link

github-actions bot commented Sep 18, 2024

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0
1 362 runs  1 361 ✔️ 1 💤 0

Results for commit 8334732.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor suggestions.
Also images or short video are great attachments to the PR to should the UI representation of the code since it can't be seen by just reviewing the code

@@ -0,0 +1,21 @@
# Wagmi Hedera Example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should add a brief summary on what Wagmi is an add a link.
For some developers this may be their first exposure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*
* Hedera JSON RPC Relay - Wagmi Example
*
* Copyright (C) 2022-2024 Hedera Hashgraph, LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new files should be fine with just the current year I believe.

Suggested change
* Copyright (C) 2022-2024 Hedera Hashgraph, LLC
* Copyright (C) 2024 Hedera Hashgraph, LLC

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (265e137) to head (8334732).
Report is 161 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3000       +/-   ##
===========================================
+ Coverage   77.06%   89.92%   +12.85%     
===========================================
  Files          40       58       +18     
  Lines        3266     3900      +634     
  Branches      683      780       +97     
===========================================
+ Hits         2517     3507      +990     
+ Misses        529      346      -183     
+ Partials      220       47      -173     
Flag Coverage Δ
relay 90.14% <ø> (?)
server 88.15% <ø> (?)
ws-server 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArianeLabs Items ArianeLabs is contributing to enhancement New feature or request
Projects
Status: For Review
Development

Successfully merging this pull request may close these issues.

5 participants