Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vault transit docs to vault integrations page #4904

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rizkybiz
Copy link

No description provided.

@rizkybiz rizkybiz requested a review from a team as a code owner June 26, 2024 10:42
Copy link
Collaborator

@stellarsquall stellarsquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't merge, just approving to run tests

Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple minor suggestions for active voice per our standards, but otherwise I think this looks great. Thank you Justin!

website/content/docs/integrations/vault/index.mdx Outdated Show resolved Hide resolved
website/content/docs/integrations/vault/index.mdx Outdated Show resolved Hide resolved
rizkybiz and others added 3 commits July 3, 2024 09:56
Committing Dan's changes.

Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
### Boundary supported key types from Vault transit

The Vault transit secrets engine provides the following key types which support the necessary operations for Boundary KMS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this feels like it's extraneous information; you could link to the transit docs for key types and say "any type that supports encryption". If those aren't spelled out in the transit docs they probably should be.

The Vault transit secrets engine supports both automatic and manual rotation of configured keys.

You can configure the Vault transit secrets engine with an [`auto_rotate_period`](https://developer.hashicorp.com/vault/api-docs/secret/transit#auto_rotate_period) to enable the automatic rotation of the configured keys. Boundary automatically rotates the keys in the backend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boundary does not do this so far as I know. @jimlambrt has more state on our KMS system at this point but I don't think the config-created KMS keys get rotated in any automatic way (and I don't remember if we support it manually at this point).

You can configure the Vault transit secrets engine with an [`auto_rotate_period`](https://developer.hashicorp.com/vault/api-docs/secret/transit#auto_rotate_period) to enable the automatic rotation of the configured keys. Boundary automatically rotates the keys in the backend.

You can also [manually rotate](/boundary/docs/concepts/security/data-encryption#key-version-lifecycle-management) keys from the Boundary API or CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rotates the internal KMS keys in Boundary, not the key in Vualt's transit engine. I believe if necessary it will re-encrypt with the external KMS, but I really don't remember if you can rotate the root KMS key. Again @jimlambrt probably has more state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants