remove all t.Parallel calls from tests

Tests take near the same time without and are much easier to work with and debug if they are sequential.
hashicorp · Jul 29, 2021 · e4a17d2 · e4a17d2
1 parent 0b1d208
commit e4a17d2
Show file tree

Hide file tree

Showing 42 changed files with 0 additions and 190 deletions.
diff --git a/child/child_test.go b/child/child_test.go
@@ -31,7 +31,6 @@ func testChild(t *testing.T) *Child {
 }
 
 func TestNew(t *testing.T) {
-	t.Parallel()
 
 	stdin := gatedio.NewByteBuffer()
 	stdout := gatedio.NewByteBuffer()
@@ -106,7 +105,6 @@ func TestNew(t *testing.T) {
 }
 
 func TestNew_errMissingCommand(t *testing.T) {
-	t.Parallel()
 
 	_, err := New(nil)
 	if err == nil {
@@ -119,7 +117,6 @@ func TestNew_errMissingCommand(t *testing.T) {
 }
 
 func TestExitCh_noProcess(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	ch := c.ExitCh()
@@ -129,7 +126,6 @@ func TestExitCh_noProcess(t *testing.T) {
 }
 
 func TestExitCh(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	if err := c.Start(); err != nil {
@@ -144,7 +140,6 @@ func TestExitCh(t *testing.T) {
 }
 
 func TestPid_noProcess(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	pid := c.Pid()
@@ -154,7 +149,6 @@ func TestPid_noProcess(t *testing.T) {
 }
 
 func TestPid(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	if err := c.Start(); err != nil {
@@ -169,7 +163,6 @@ func TestPid(t *testing.T) {
 }
 
 func TestStart(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 
@@ -204,7 +197,6 @@ func TestStart(t *testing.T) {
 }
 
 func TestSignal(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.command = "sh"
@@ -235,7 +227,6 @@ func TestSignal(t *testing.T) {
 }
 
 func TestSignal_noProcess(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	if err := c.Signal(syscall.SIGUSR1); err != nil {
@@ -245,7 +236,6 @@ func TestSignal_noProcess(t *testing.T) {
 }
 
 func TestReload_signal(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.command = "sh"
@@ -277,7 +267,6 @@ func TestReload_signal(t *testing.T) {
 }
 
 func TestReload_noSignal(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.command = "sh"
@@ -312,7 +301,6 @@ func TestReload_noSignal(t *testing.T) {
 }
 
 func TestReload_noProcess(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.reloadSignal = syscall.SIGUSR1
@@ -322,7 +310,6 @@ func TestReload_noProcess(t *testing.T) {
 }
 
 func TestKill_signal(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.command = "sh"
@@ -352,7 +339,6 @@ func TestKill_signal(t *testing.T) {
 }
 
 func TestKill_noSignal(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.command = "sh"
@@ -379,15 +365,13 @@ func TestKill_noSignal(t *testing.T) {
 }
 
 func TestKill_noProcess(t *testing.T) {
-	t.Parallel()
 
 	c := testChild(t)
 	c.killSignal = syscall.SIGUSR1
 	c.Kill()
 }
 
 func TestStop_noWaitForSplay(t *testing.T) {
-	t.Parallel()
 	c := testChild(t)
 	c.command = "sh"
 	c.args = []string{"-c", "trap 'echo one; exit' USR1; while true; do sleep 0.2; done"}
@@ -420,7 +404,6 @@ func TestStop_noWaitForSplay(t *testing.T) {
 }
 
 func TestStop_childAlreadyDead(t *testing.T) {
-	t.Parallel()
 	c := testChild(t)
 	c.command = "sh"
 	c.args = []string{"-c", "exit 1"}

diff --git a/cli_test.go b/cli_test.go
@@ -16,7 +16,6 @@ import (
 )
 
 func TestCLI_ParseFlags(t *testing.T) {
-	t.Parallel()
 
 	f, err := ioutil.TempFile("", "")
 	if err != nil {
@@ -736,7 +735,6 @@ func TestCLI_ParseFlags(t *testing.T) {
 }
 
 func TestCLI_Run(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -787,7 +785,6 @@ func TestCLI_Run(t *testing.T) {
 	}
 
 	t.Run("once", func(t *testing.T) {
-		t.Parallel()
 
 		f, err := ioutil.TempFile("", "")
 		if err != nil {
@@ -839,7 +836,6 @@ func TestCLI_Run(t *testing.T) {
 	})
 
 	t.Run("reload", func(t *testing.T) {
-		t.Parallel()
 
 		f, err := ioutil.TempFile("", "")
 		if err != nil {

diff --git a/config/auth_test.go b/config/auth_test.go
@@ -7,7 +7,6 @@ import (
 )
 
 func TestParseAuthConfig(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -54,7 +53,6 @@ func TestParseAuthConfig(t *testing.T) {
 }
 
 func TestAuthConfig_Copy(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -89,7 +87,6 @@ func TestAuthConfig_Copy(t *testing.T) {
 }
 
 func TestAuthConfig_Merge(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -206,7 +203,6 @@ func TestAuthConfig_Merge(t *testing.T) {
 }
 
 func TestAuthConfig_Finalize(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -246,7 +242,6 @@ func TestAuthConfig_Finalize(t *testing.T) {
 }
 
 func TestAuthConfig_String(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string

diff --git a/config/config_test.go b/config/config_test.go
@@ -36,7 +36,6 @@ func testFile(t *testing.T, contents string) (path string, remove func()) {
 }
 
 func TestParse(t *testing.T) {
-	t.Parallel()
 
 	testFilePath, remove := testFile(t, "")
 	defer remove()
@@ -1571,7 +1570,6 @@ func TestParse(t *testing.T) {
 }
 
 func TestFinalize(t *testing.T) {
-	t.Parallel()
 
 	testFileContents := "testing123"
 	testFilePath, remove := testFile(t, testFileContents)
@@ -1676,7 +1674,6 @@ func TestFinalize(t *testing.T) {
 }
 
 func TestConfig_Merge(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -1943,7 +1940,6 @@ func TestConfig_Merge(t *testing.T) {
 }
 
 func TestFromPath(t *testing.T) {
-	t.Parallel()
 
 	f, err := ioutil.TempFile("", "")
 	if err != nil {

diff --git a/config/consul_test.go b/config/consul_test.go
@@ -8,7 +8,6 @@ import (
 )
 
 func TestConsulConfig_Copy(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -49,7 +48,6 @@ func TestConsulConfig_Copy(t *testing.T) {
 }
 
 func TestConsulConfig_Merge(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string
@@ -262,7 +260,6 @@ func TestConsulConfig_Merge(t *testing.T) {
 }
 
 func TestConsulConfig_Finalize(t *testing.T) {
-	t.Parallel()
 
 	cases := []struct {
 		name string