Preserve destination file ownership on unix OSes #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pearkes
approved these changes
Feb 16, 2019
|
Talked about how it would be great to get tests in but unsure of how that would be possible in CI. |
deblasis
added a commit
to deblasis/consul-template
that referenced
this pull request
Nov 3, 2021
Related issues hashicorp#639, hashicorp#1497, hashicorp#1185 and also nomad/5020 Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the renderer to preserve the destination file permissions when possible (on operating systems that support Go's FileInfo.Sys() interface).
Fixes #1061.