Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document limits on using dots in service names #1220

Merged
merged 1 commit into from
Jun 26, 2019
Merged

document limits on using dots in service names #1220

merged 1 commit into from
Jun 26, 2019

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Jun 24, 2019

Fixes #1205

@eikenb eikenb requested review from a team June 24, 2019 21:35
judithpatudith
judithpatudith reviewed Jun 25, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
judithpatudith
judithpatudith reviewed Jun 25, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@eikenb eikenb merged commit c20664f into master Jun 26, 2019
@eikenb eikenb added this to the v0.20.1 milestone Jun 26, 2019
@eikenb eikenb deleted the issue1205 branch July 18, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judithpatudith judithpatudith judithpatudith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.1
Development

Successfully merging this pull request may close these issues.

Can't grab instances that service.Name include "."
2 participants
@eikenb @judithpatudith