Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loop to work with different int types #1255

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Aug 9, 2019

fix loop to work with different int types

@eikenb eikenb requested review from a team August 9, 2019 21:48
@eikenb eikenb added the bug label Aug 9, 2019
@eikenb eikenb added this to the 0.21.1 milestone Aug 9, 2019
`loop` when passed a scrach or $variable that contained an int as the
function was typed to only take int64. This changes it more like the
other functions that takes a interface{} and type switches/converts it
using reflect. Made it handle integer strings while I was at it.

Fixes #1143
Copy link

@s-mang s-mang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks right to me!

@eikenb eikenb merged commit ba332ca into master Aug 12, 2019
@eikenb eikenb deleted the issue1143-loop-int64-type branch August 13, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants