Issue 1262 consul connect #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
reviewed
Nov 8, 2019
rboyer
reviewed
Nov 8, 2019
rboyer
reviewed
Nov 8, 2019
rboyer
reviewed
Nov 8, 2019
Wrappers that call consul's connect API for use with template setup.
Wraps connect root/leaf fetching calls with template functions so you can write the certs out using templates.
Wraps /health/connect. Uses same code as `service` as both /health/service and /health/connect have the same API except for the actual data. Note that in the consul code they are handled similarly, with connect and service sharing the same codebase.
Template function call for connect health service wrapper. Plus tests.
Current version (1.5.1) has a bug in the connect leaf code, returning a 500 error; "SPIFFE ID is not in the expected format". Updating to 1.5.2+ fixes this. I'm updating to latest stable (1.6.1) while I'm here doing it.
eikenb
force-pushed
the
issue-1262-consul-connect
branch
from
ba67f7d
to
7b3308c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Consul Connect support. Target is to allow proxies (nginx, haproxy) to route directly to services inside the mesh network. This is the basic support and reference docs. I'm still working on some examples/intros for each.