-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nginx/haproxy connect example documentation #1306
Conversation
f183d27
to
269b1e0
Compare
269b1e0
to
b2dd438
Compare
Thanks for all the suggestions @kaitlincarter-hc! Super helpful and nice of you. I've made all the suggested text changes except regarding the script/config-files. Regard them, I went back and forth on having the config files already in the repo vs. having them generated by the script. There are a couple(ish) options.
I went with the 2 as it kept things cleaner and I figured if the person was technical enough to run the tests, they could figure out how to use the script. Switching to 1 would, I think, make it easier to run the tests at the expense of cluttering things up a bit. I would split the script into 2 parts if I did that. One to extract the config and template files and one to actually run the tests (which would also simplify it a bit). Do you think 1 would be better? Thanks again. |
I think for the repo, option 2 is probably better. For the Learn guide I'll simplify things a little! |
81b6032
to
2b46da7
Compare
includes helper script to extract config files and run commands in screen session.
2b46da7
to
6dfd298
Compare
Made a few tweaks and included the haproxy doc (which was based on nginx one and nearly identical... so I figured it has already been reviewed). |
includes helper script to extract config files and run command in screen
session.