fix bug looking up versioned vault secrets #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
force-pushed
the
issue-1350-versioned-brains
branch
from
30c192f
to
f54cce4
Compare
The brains/cache is keyed off String() output of a dependency. In this case the dependency is a versioned vault secret. The problem is that the vault secret's String() output doesn't contain the version. So the first version retrieved seeds the cache and all subsequent references use that version even if they specify a different (or no) version. Including the version in vault secret String() output fixes this.
eikenb
force-pushed
the
issue-1350-versioned-brains
branch
from
f54cce4
to
d94fe0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brains/cache is keyed off String() output of a dependency. In this
case the dependency is a versioned vault secret. The problem is that the
vault secret's String() output doesn't contain the version. So the first
version retrieved seeds the cache and all subsequent references use that
version even if they specify a different (or no) version.
Including the version in vault secret String() output fixes this.
Fixes #1350