Fix/master: add envOrDefault helper #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a helper function called envOrDefault which behaves similar to keyOrDefault If an environment variable exists and its value has a non-zero length, that value will be used, otherwise the default value specified will be used.
|
|
|
Hi @eikenb here's the PR for the envOrDefault helper |
eikenb
reviewed
Apr 23, 2021
eikenb
added
hashicat-update-required
This accepts environment variables that are set to empty string. The only time default will be used is if the variable is not present.
Update the documentation for the new behavior of envOrDefault with respect to environment variables which are set but to empty strings.
eikenb
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #829
Adds a helper
envOrDefaultas a compliment to theenvhelper. This behaves similar to howkeyOrDefaultbehaves.The helper will attempt to retrieve an environment variable. If the variable is found and if the value has a non-zero length, the value is used. Otherwise, the default value is used.
Change includes tests and documentation.