Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support command lists #1543

Merged
merged 1 commit into from
Feb 10, 2022
Merged

support command lists #1543

merged 1 commit into from
Feb 10, 2022

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Feb 9, 2022

This updates the exec{} block's command setting to support command lists.
That is a command formatted like ["echo", "hello", "world"].
It is backwards compatible with the old format, turning single commands
w/o spaces into lists.
Single commands with spaces still use the sh -c setup.

This will allow for multi-word commands on Windows and in setups (like
bare docker containers) without sh installed.

Fixes: #1518
Fixes: #1530 (doc fix I did at same time)

@eikenb eikenb added this to the v0.28.0 milestone Feb 9, 2022
@eikenb eikenb requested a review from a team February 9, 2022 22:46
@mkam mkam requested review from mkam and removed request for a team February 10, 2022 15:49
Copy link

@mkam mkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
This updates the exec{} block's `command` setting to support command lists.
That is a command formatted like `["echo", "hello", "world"]`.
It is backwards compatible with the old format, turning single commands
w/o spaces into lists.
Single commands with spaces still use the `sh -c` setup.

This will allow for multi-word commands on Windows and in setups (like
bare docker containers) without `sh` installed.
@eikenb eikenb merged commit be5fcd8 into master Feb 10, 2022
@eikenb eikenb deleted the command-exec-list branch February 10, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Exec{} block as part of template configuration Support command/exec lists
2 participants