add new pkiCert template function #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
commented
Mar 30, 2022
| return nil, fmt.Errorf("no secret exists at %s", d.pkiPath) | ||
| } | ||
| printVaultWarnings(d, vaultSecret.Warnings) | ||
| encPEM, ok := vaultSecret.Data["certificate"].(string) |
There was a problem hiding this comment.
Interesting Go-ism for the reviewer. The 'ok' here is both for the dictionary lookup and the type assertion. If the dictionary is missing the key it will be set to false and if the type assertion fails the same. Hadn't realized you could chain ok tests like that.
wilkermichael
approved these changes
Mar 31, 2022
eikenb
force-pushed
the
pki-template-function
branch
3 times, most recently
from
c8f2eb8
to
863b7d7
Compare
The new pkiCert template function and its dependency. Common PKI dependency testing setup code was placed in vault_common and called in TestMain. Documentation and template tests round things out. Most of this is pretty standard new-template-function stuff. The main differing point for this Dependency is that it is specialized to the certificate and uses the rendered template destination file as a cache for the certificate, reading it in and checking the dates to see if it is still valid. If so it reuses it, it not (or if it's not there) it fetches a new one. It tries to handle this 'cache' file as forgivingly as possible, skipping over other CA certificates and text for the PEM encoded/formatted certificate. It should skip any CA, root or intermediary/chain.
eikenb
force-pushed
the
pki-template-function
branch
from
863b7d7
to
56b5521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pkiCert template function and its dependency. Common PKI dependency testing setup code was placed in vault_common and called in TestMain. Documentation and template tests round things out.
Most of this is pretty standard new-template-function stuff. The main differing point for this Dependency is that it is specialized to the certificate and uses the rendered template destination file as a cache for the certificate, reading it in and checking the dates to see if it is still valid. If so it reuses it, if not (or if it's not there) it fetches a new one. It tries to handle this 'cache' file as forgivingly as possible, skipping over other CA certificates and text for the PEM encoded/formatted certificate. It should skip any CA, root or intermediary/chain.
Fixes #1259