fix bug with 2 templates, same ID, different paths #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way template configs were being tracked meant that if 2 templates had the same content but different config otherwise, they would only use the last config. Having more than 1 template with the same content is rare but a user ran into it with 2 templates and the same path. This eliminates the separate tracking of template configs and bundles them with the templates themselves. Having a 1-1 template/config and eliminating the separate data structure makes this area of code simpler to understand and work with while fixing this issue. This also fixes the TemplateConfigMapping() call which should have kept backwards compatibility with the signature.
eikenb
force-pushed
the
same-template-diff-paths
branch
from
56093c6
to
ba3331d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way template configs were being tracked meant that if 2 templates
had the same content but different config otherwise, they would only use
the last config. Having more than 1 template with the same content is
rare but a user ran into it with 2 templates and the same path.
This eliminates the separate tracking of template configs and bundles
them with the templates themselves. Having a 1-1 template/config and
eliminating the separate data structure makes this area of code simpler
to understand and work with while fixing this issue.
This also fixes the TemplateConfigMapping() call which should have kept
backwards compatibility with the signature.