make sure pki IDs are unique #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a classic cut-n-paste error. The PKI code was based on the existing vault_read.go 'secret' code and missed the fact that the ID of the pkiCert will be identical for all certs pulled form the same PKI role path. The fix will be to adjust the ID to be composed of the pki role path + the destination path. That should be unique per use case as the destination path must be unique per Cert.
eikenb
force-pushed
the
issue-1607-pki-cert-unique-ids
branch
from
7965a3c
to
02774d9
Compare
eikenb
added
the
hashicat-update-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a classic cut-n-paste error. The PKI code was based on the
existing vault_read.go 'secret' code and missed the fact that the ID of
the pkiCert will be identical for all certs pulled form the same PKI
role path.
The fix will be to adjust the ID to be composed of the pki role path +
the destination path. That should be unique per use case as the
destination path must be unique per Cert.
Fixes #1607