Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isChownNeeded bad when only user/group (!both) set #1652

Merged
merged 1 commit into from
Oct 4, 2022
Merged

isChownNeeded bad when only user/group (!both) set #1652

merged 1 commit into from
Oct 4, 2022

Commits on Oct 3, 2022

  1. isChownNeeded bad when only user/group (!both) set 

    isChownNeeded returned the wrong result if either (exclusive) user or
group were set but not the other. It uses a guard value but only
compares both at the start and doesn't take this into account on the
final comparison which compares both against the current values.

IE. it always returns true in these cases as the guard value is never
going to be the same as an real file value.
    @eikenb
    eikenb committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    cc197b2 View commit details
    Browse the repository at this point in the history