Re-add error for loading HCP management token

hashicorp · Jul 17, 2023 · f1225f5 · f1225f5
1 parent a8c6609
commit f1225f5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/agent/hcp/bootstrap/bootstrap.go b/agent/hcp/bootstrap/bootstrap.go
@@ -457,7 +457,7 @@ func loadManagementToken(dir string) (string, error) {
 	bytes, err := os.ReadFile(name)
 	if os.IsNotExist(err) {
 		// A missing management token is not an error, if none was provided by HCP
-		return "", nil
+		return "", errors.New("configuration files on disk are incomplete, missing: " + name)
 	}
 	if err != nil {
 		return "", fmt.Errorf("failed to read: %w", err)

diff --git a/agent/hcp/bootstrap/bootstrap_test.go b/agent/hcp/bootstrap/bootstrap_test.go
@@ -372,7 +372,7 @@ func Test_loadPersistedBootstrapConfig(t *testing.T) {
 			existingCluster:        true,
 			disableManagementToken: true,
 			expect: expect{
-				loaded: true,
+				loaded: false,
 			},
 		},
 		"existing cluster no files": {
@@ -398,7 +398,7 @@ func Test_loadPersistedBootstrapConfig(t *testing.T) {
 		"new cluster with no token": {
 			disableManagementToken: true,
 			expect: expect{
-				loaded: true,
+				loaded: false,
 			},
 		},
 		"new cluster some files": {