Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: Fix language to describe clients previously ran on each node into release/1.14.x #15591

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #15580 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "d54f3d213528094b766b05eeb19ebd7d20f6c5cb", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Describe why you're making this change, in plain English.

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/fix-language-dataplane/horribly-solid-marmot branch from 78b541c to 237b7ae Compare November 28, 2022 22:51
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Nov 28, 2022
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@david-yu david-yu marked this pull request as ready for review November 29, 2022 00:52
@david-yu david-yu requested a review from a team as a code owner November 29, 2022 00:52
@david-yu david-yu merged commit 72eccca into release/1.14.x Nov 29, 2022
@david-yu david-yu deleted the backport/docs/fix-language-dataplane/horribly-solid-marmot branch November 29, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants