tests: Pin api submodule to compatibile version for upgrade tests #15830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #15827. The details are in #15827 but the gist is that because the upgrade tests use the latest version of the
api
submodule, the test code will fail when running against a Consul 1.14 container instance because it is sending a config field that is not known. I was able to pull in a compatible api submodule using areplace
directive. It seems to work, so I'm wondering if we should use this instead of removing the test code that triggers the compatibility issue.Testing & Reproduction steps