Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Updated docs added explanation. into release/1.14.x #17790

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #17751 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Updated docs added explanation for #17582 (comment)


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 16, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • absolutelightning
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/asheshvidyut/NET-3865/endlessly-up-colt branch 2 times, most recently from bc76c83 to 1f04ed0 Compare June 16, 2023 15:49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 16, 2023 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 16, 2023 15:57 Inactive
absolutelightning and others added 3 commits June 21, 2023 11:28
* init

* fix tests

* added -detailed in docs

* added change log

* fix doc

* checking for entry in map

* fix tests

* removed detailed flag

* removed detailed flag

* revert unwanted changes

* removed unwanted changes

* updated change log

* pr review comment changes

* pr comment changes single API instead of two

* fix change log

* fix tests

* fix tests

* fix test operator raft endpoint test

* Update .changelog/17582.txt

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>

* nits

* updated docs

* explanation added

---------

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
…h://github.com/hashicorp/consul into backport/asheshvidyut/NET-3865/endlessly-up-colt
@absolutelightning absolutelightning marked this pull request as ready for review June 21, 2023 06:00
@absolutelightning absolutelightning requested a review from a team as a code owner June 21, 2023 06:00
@absolutelightning absolutelightning merged commit 6ed5e36 into release/1.14.x Jun 21, 2023
@absolutelightning absolutelightning deleted the backport/asheshvidyut/NET-3865/endlessly-up-colt branch June 21, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants