Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration #18168

Merged
merged 42 commits into from
Aug 1, 2023
Merged

[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration #18168

merged 42 commits into from
Aug 1, 2023

Commits on Jul 31, 2023

  1. OTElExporter now uses an EndpointProvider to discover the endpoint

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    00cee32 View commit details
    Browse the repository at this point in the history

  2. OTELSink uses a ConfigProvider to obtain filters and labels configura… 

    …tion
    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    77f09b8 View commit details
    Browse the repository at this point in the history

  3. improve tests for otel_sink

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ff4d85f View commit details
    Browse the repository at this point in the history

  4. Regex logic is moved into client for a method on the TelemetryConfig … 

    …object
    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0264d5b View commit details
    Browse the repository at this point in the history

  5. Create a telemetry_config_provider and update deps to use it

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f12219a View commit details
    Browse the repository at this point in the history

  6. Fix conversion

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8b4bf1d View commit details
    Browse the repository at this point in the history

  7. fix import newline

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5b4c997 View commit details
    Browse the repository at this point in the history

  8. Add logger to hcp client and move telemetry_config out of the client.… 

    …go file
    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    7550818 View commit details
    Browse the repository at this point in the history

  9. Add a telemetry_config.go to refactor client.go

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3f1c53d View commit details
    Browse the repository at this point in the history

  10. Update deps

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8dce916 View commit details
    Browse the repository at this point in the history

  11. update hcp deps test

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2313673 View commit details
    Browse the repository at this point in the history

  12. Modify telemetry_config_providers

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    196a4ef View commit details
    Browse the repository at this point in the history

  13. Check for nil filters

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3b031a2 View commit details
    Browse the repository at this point in the history

  14. PR review updates

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    cb869b1 View commit details
    Browse the repository at this point in the history

  15. Fix comments and move around pieces

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    38d6bca View commit details
    Browse the repository at this point in the history

  16. Fix comments

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1feea25 View commit details
    Browse the repository at this point in the history

  17. Remove context from client struct

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0d25ba4 View commit details
    Browse the repository at this point in the history

  18. Moved ctx out of sink struct and fixed filters, added a test

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a58baa7 View commit details
    Browse the repository at this point in the history

  19. Remove named imports, use errors.New if not fformatting

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f3be3ec View commit details
    Browse the repository at this point in the history

  20. Remove HCP dependencies in telemetry package

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a353527 View commit details
    Browse the repository at this point in the history

  21. Add success metric and move lock only to grab the t.cfgHahs

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    de55bf9 View commit details
    Browse the repository at this point in the history

  22. Update hash

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    eacf20e View commit details
    Browse the repository at this point in the history

  23. fix nits

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4ed2b74 View commit details
    Browse the repository at this point in the history

  24. Create an equals method and add tests

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e3839b3 View commit details
    Browse the repository at this point in the history

  25. Improve telemetry_config_provider.go tests

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b867e30 View commit details
    Browse the repository at this point in the history

  26. Add race test

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d4b788a View commit details
    Browse the repository at this point in the history

  27. Add missing godoc

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    932633e View commit details
    Browse the repository at this point in the history

  28. Remove mock for MetricsClient

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    696966f View commit details
    Browse the repository at this point in the history

  29. Avoid goroutine test panics

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1d58bf6 View commit details
    Browse the repository at this point in the history

  30. trying to kick CI lint issues by upgrading mod

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fea50d4 View commit details
    Browse the repository at this point in the history

  31. imprve test code and add hasher for testing

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    bfebfb1 View commit details
    Browse the repository at this point in the history

  32. Use structure logging for filters, fix error constants, and default t… 

    …o allow all regex
    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    54eb748 View commit details
    Browse the repository at this point in the history

  33. removed hashin and modify logic to simplify

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9677781 View commit details
    Browse the repository at this point in the history

  34. Improve race test and fix PR feedback by removing hash equals and avo… 

    …id testing the timer.Ticker logic, and instead unit test
    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c23798c View commit details
    Browse the repository at this point in the history

  35. Ran make go-mod-tidy

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    235acac View commit details
    Browse the repository at this point in the history

  36. Use errtypes in the test

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1ef0795 View commit details
    Browse the repository at this point in the history

  37. Add changelog

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2e10100 View commit details
    Browse the repository at this point in the history

  38. add safety check for exporter endpoint

    @Achooo
    Achooo committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    952129c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. remove require.Contains by using error types, fix structure logging, … 

    …and fix success metric typo in exporter
    @Achooo
    Achooo committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b46d5b9 View commit details
    Browse the repository at this point in the history

  2. Fixed race test to have changing config values

    @Achooo
    Achooo committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7ea6280 View commit details
    Browse the repository at this point in the history

  3. Send success metric before modifying config

    @Achooo
    Achooo committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d3522ee View commit details
    Browse the repository at this point in the history

  4. Avoid the defer and move the success metric under

    @Achooo
    Achooo committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    aaec9a6 View commit details
    Browse the repository at this point in the history