Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register ProxyStateTemplate Resource #18316

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Register ProxyStateTemplate Resource #18316

merged 2 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. Register ProxyStateTemplateResource 

    * also change the ProxyState.id to identity. This is because we already have the id of this proxy
  from the resource, and this id should be name-aligned with the workload it represents. It should
  also have the owner ref set to the workload ID if we need that. And so the id field seems unnecessary.
  We do, however, need a reference to workload identity so that we can authorize the proxy when it initially
  connects to the xDS server.
    @ishustava
    ishustava committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9f0ab4b View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @ishustava
    ishustava committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    43f3793 View commit details
    Browse the repository at this point in the history