-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: avoid redundant logs on failures to export metrics #20519
Conversation
Backport failed @jjti. Run: https://github.com/hashicorp/consul/actions/runs/7832377374 |
Backport failed @jjti. Run: https://github.com/hashicorp/consul/actions/runs/7832377374 |
@jjti, a backport is missing for this PR [20519] for versions [1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:
|
3 similar comments
@jjti, a backport is missing for this PR [20519] for versions [1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:
|
@jjti, a backport is missing for this PR [20519] for versions [1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:
|
@jjti, a backport is missing for this PR [20519] for versions [1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:
|
Description
I'm seeing redundant log lines on failures to push metrics to HCP:
We log in two places:
consul/agent/hcp/client/metrics_client.go
Line 75 in 47c5c8b
The fix here is to pass a NullLogger to the http client so:
hcp.telemetry
group logs: Fix logging when we fail to export metrics to hcp #20514An alternative approach is to combine this PR with the other logging-related PR: #20514. And:
ExportMetrics
Testing & Reproduction steps
Links
PR Checklist