Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test-integrations.yml to capture latest versions of Nomad and Vault #21749

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Update test-integrations.yml to capture latest versions of Nomad and Vault #21749

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0179941
Update test-integrations.yml
NicoletaPopoviciu Sep 17, 2024
b20d018
Update test to test latest available CE versions
NicoletaPopoviciu Sep 17, 2024
61a85b0
Merge branch 'main' into nicoleta-NET-9589
NicoletaPopoviciu Sep 17, 2024
974f90c
Merge branch 'main' into nicoleta-NET-9589
NicoletaPopoviciu Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-integrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
contents: read
strategy:
matrix:
nomad-version: ['v1.7.7', 'v1.6.10', 'v1.5.17']
nomad-version: ['v1.8.3', 'v1.7.11', 'v1.6.15']
steps:
- name: Checkout Nomad
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
Expand Down Expand Up @@ -177,7 +177,7 @@ jobs:
contents: read
strategy:
matrix:
vault-version: ["1.16.2", "1.15.6", "1.14.10"]
vault-version: ["1.17.5", "1.16.9", "1.15.14"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://releases.hashicorp.com/vault, I think the latest CE release for 1.15 was 1.15.6 - that's why the download of https://releases.hashicorp.com/vault/1.15.14/vault_1.15.14_linux_amd64.zip (doesn't include+ent, so it's not a valid download URL) is failing. Similar story for Nomad: https://releases.hashicorp.com/nomad.

This is similar to the issue we ran into w/ consul-k8s acceptance tests once consul CE moved out of maintenance for all but the latest CE version.

Our options here are to either:

  • Use the latest CE versions
  • Start pulling Ent versions and configure licenses as secrets in CI to test them

The downside of the second option is that any community PRs against consul (CE) will fail integration tests, requiring an employee w/ repo write access to run them in order to gain access to the license secrets.

The way around this, and the approach I'd probably recommend, is testing CE versions in CE, and Ent versions in Ent. That would create a cleaner separation, but take a bit more time since we'll need to reconfigure each repo's jobs to target different release binaries. Shouldn't be too much work, but probably worth filing a ticket and putting some heads together since it won't be a simple bump anymore.

For now, we can go ahead and update to the latest CE versions:

  • Vault: 1.17.5, 1.16.3, 1.15.6
  • Nomad: 1.8.3, 1.7.7, 1.6.10

env:
VAULT_BINARY_VERSION: ${{ matrix.vault-version }}
steps:
Expand Down
Loading