Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update policy_set to support project relationship on CREATE #737

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update policy_set to support project relationship on CREATE #737

merged 1 commit into from
Jul 18, 2023

Conversation

hs26gill
Copy link
Contributor

@hs26gill hs26gill commented Jul 13, 2023 •
edited
Loading

Description

This PR provide users with the ability to apply projects when creating a new policy set. This feature is currently behind a feature flag in production

Testing plan

Integration test is added to complete the testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run policy_set_integration_test.go

=== RUN   TestPolicySetsCreate
--- PASS: TestPolicySetsCreate (2.65s)
=== RUN   TestPolicySetsCreate/with_policies_and_projects_provided
    --- PASS: TestPolicySetsCreate/with_policies_and_projects_provided (1.63s)
PASS

@hs26gill hs26gill requested a review from a team as a code owner July 13, 2023 21:15
@hs26gill hs26gill force-pushed the hs26gill/TF-6272-create-policy-set-with-project-params branch 3 times, most recently from 2ea0533 to 04b414f Compare July 13, 2023 21:27
Netra2104
Netra2104 previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Netra2104 Netra2104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few minor comments and questions. Looks great overall 💯

policy_set_integration_test.go Outdated Show resolved Hide resolved
policy_set_integration_test.go Show resolved Hide resolved
policy_set_integration_test.go Outdated Show resolved Hide resolved
policy_set.go Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-6272-create-policy-set-with-project-params branch 2 times, most recently from b05e86a to d90bf32 Compare July 18, 2023 16:49
brandonc
brandonc reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny CHANGELOG issue

CHANGELOG.md Outdated Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-6272-create-policy-set-with-project-params branch from d90bf32 to 36bba36 Compare July 18, 2023 17:59
@hs26gill hs26gill force-pushed the hs26gill/TF-6272-create-policy-set-with-project-params branch from 36bba36 to 8ad1bf9 Compare July 18, 2023 18:01
@hs26gill hs26gill merged commit 29b2afa into main Jul 18, 2023
9 checks passed
@hs26gill hs26gill deleted the hs26gill/TF-6272-create-policy-set-with-project-params branch July 18, 2023 21:02
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonc brandonc brandonc approved these changes

@Netra2104 Netra2104 Netra2104 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hs26gill @brandonc @Netra2104