Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF-9605] Add the tags attribute to VCSRepo #793

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[TF-9605] Add the tags attribute to VCSRepo #793

merged 1 commit into from
Oct 13, 2023

Conversation

hashimoon
Copy link
Contributor

@hashimoon hashimoon commented Oct 12, 2023 •
edited
Loading

Description

This is required to prevent terraform always from always asserting new state changes when toggling between a branch and tag based publishing for RegistryModules

Testing plan

  1. Create a RegistryModule
  2. Verify that VCSRepo.Branch and VCSRepo.Tags are returned in the response
  3. Update a RegistryModule
  4. Verify that VCSRepo.Branch and VCSRepo.Tags are returned in the response

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestRegistryModulesCreate
=== RUN   TestRegistryModulesCreate
=== RUN   TestRegistryModulesCreate/with_valid_options
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute
2023/10/12 20:54:43 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to create a no-code module is with the registryNoCodeModules.Create method.
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_invalid_options
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name
=== RUN   TestRegistryModulesCreate/without_a_valid_organization
--- PASS: TestRegistryModulesCreate (2.05s)
    --- PASS: TestRegistryModulesCreate/with_valid_options (0.83s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName (0.18s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName (0.17s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName (0.30s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute (0.18s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreate/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name (0.00s)
    --- PASS: TestRegistryModulesCreate/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesCreateVersion
=== RUN   TestRegistryModulesCreateVersion/with_valid_options
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/without_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version
=== RUN   TestRegistryModulesCreateVersion/without_a_name
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_name
=== RUN   TestRegistryModulesCreateVersion/without_a_provider
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesCreateVersion/without_a_valid_organization
--- PASS: TestRegistryModulesCreateVersion (2.28s)
    --- PASS: TestRegistryModulesCreateVersion/with_valid_options (0.22s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version (0.20s)
    --- PASS: TestRegistryModulesCreateVersion/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/without_version (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesCreateWithVCSConnection
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/without_options
--- PASS: TestRegistryModulesCreateWithVCSConnection (5.13s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options (1.32s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/without_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection (5.03s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options (1.33s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting (5.40s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options (1.39s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled (0.00s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled (0.00s)
=== RUN   TestRegistryModulesCreateWithGithubApp
    registry_module_integration_test.go:974: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestRegistryModulesCreateWithGithubApp (0.00s)
=== RUN   TestRegistryModulesCreate
=== RUN   TestRegistryModulesCreate/with_valid_options
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute
2023/10/12 20:55:03 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to create a no-code module is with the registryNoCodeModules.Create method.
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_invalid_options
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name
=== RUN   TestRegistryModulesCreate/without_a_valid_organization
--- PASS: TestRegistryModulesCreate (2.34s)
    --- PASS: TestRegistryModulesCreate/with_valid_options (0.77s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName (0.19s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName (0.16s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName (0.17s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute (0.24s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreate/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name (0.00s)
    --- PASS: TestRegistryModulesCreate/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesCreateVersion
=== RUN   TestRegistryModulesCreateVersion/with_valid_options
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/without_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version
=== RUN   TestRegistryModulesCreateVersion/without_a_name
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_name
=== RUN   TestRegistryModulesCreateVersion/without_a_provider
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesCreateVersion/without_a_valid_organization
--- PASS: TestRegistryModulesCreateVersion (2.56s)
    --- PASS: TestRegistryModulesCreateVersion/with_valid_options (0.24s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version (0.31s)
    --- PASS: TestRegistryModulesCreateVersion/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/without_version (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesCreateWithVCSConnection
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/without_options
--- PASS: TestRegistryModulesCreateWithVCSConnection (5.03s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options (1.27s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/without_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection (5.18s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options (1.41s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting (5.13s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options (1.36s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled (0.00s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled (0.00s)
=== RUN   TestRegistryModulesCreateWithGithubApp
    registry_module_integration_test.go:974: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestRegistryModulesCreateWithGithubApp (0.00s)
PASS
ok  	github.com/hashicorp/go-tfe	40.462s
...

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestRegistryModuleUpdate
=== RUN   TestRegistryModuleUpdate
=== RUN   TestRegistryModuleUpdate/enable_no-code
2023/10/12 20:59:15 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdate/disable_no-code
2023/10/12 20:59:16 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
--- PASS: TestRegistryModuleUpdate (2.10s)
    --- PASS: TestRegistryModuleUpdate/enable_no-code (0.36s)
    --- PASS: TestRegistryModuleUpdate/disable_no-code (0.46s)
=== RUN   TestRegistryModuleUpdateWithVCSConnection
=== RUN   TestRegistryModuleUpdateWithVCSConnection/enable_no-code
2023/10/12 20:59:19 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/disable_no-code
2023/10/12 20:59:20 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing
--- PASS: TestRegistryModuleUpdateWithVCSConnection (6.17s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/enable_no-code (0.30s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/disable_no-code (0.19s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing (0.62s)
=== RUN   TestRegistryModuleUpdate
=== RUN   TestRegistryModuleUpdate/enable_no-code
2023/10/12 20:59:24 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdate/disable_no-code
2023/10/12 20:59:24 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
--- PASS: TestRegistryModuleUpdate (2.55s)
    --- PASS: TestRegistryModuleUpdate/enable_no-code (0.33s)
    --- PASS: TestRegistryModuleUpdate/disable_no-code (0.42s)
=== RUN   TestRegistryModuleUpdateWithVCSConnection
=== RUN   TestRegistryModuleUpdateWithVCSConnection/enable_no-code
2023/10/12 20:59:28 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/disable_no-code
2023/10/12 20:59:29 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing
--- PASS: TestRegistryModuleUpdateWithVCSConnection (6.73s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/enable_no-code (0.37s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/disable_no-code (0.30s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing (0.83s)
PASS
ok  	github.com/hashicorp/go-tfe	17.901s

@hashimoon hashimoon force-pushed the hashimoon/TF-9605-vcs-repo-tags branch 3 times, most recently from aaab547 to 772ff13 Compare October 13, 2023 03:48
@hashimoon
[TF-9605] Add the tags attribute to VCSRepo
5f5abd4 
This is required to prevent terraform always from always asserting new state changes when toggling between a branch and tag based publishing for RegistryModules
@hashimoon hashimoon force-pushed the hashimoon/TF-9605-vcs-repo-tags branch from 772ff13 to 5f5abd4 Compare October 13, 2023 03:59
@hashimoon hashimoon marked this pull request as ready for review October 13, 2023 04:02
@hashimoon hashimoon requested a review from a team as a code owner October 13, 2023 04:02
@hashimoon hashimoon force-pushed the hashimoon/TF-9605-vcs-repo-tags branch from 38e8379 to 5f5abd4 Compare October 13, 2023 15:15
@aaabdelgany aaabdelgany merged commit 495e080 into main Oct 13, 2023
19 checks passed
@aaabdelgany aaabdelgany deleted the hashimoon/TF-9605-vcs-repo-tags branch October 13, 2023 16:42
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uk1288 Uk1288 Uk1288 approved these changes

@aaabdelgany aaabdelgany Awaiting requested review from aaabdelgany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hashimoon @Uk1288 @aaabdelgany