[WAYP-2742] Support no-code workspace upgrades #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uturunku1
requested changes
Jul 26, 2024
| @@ -284,6 +295,34 @@ func (r *registryNoCodeModules) CreateWorkspace( | |||
| return w, nil | |||
| } | |||
|
|
|||
| func (r *registryNoCodeModules) UpgradeWorkspace( | |||
There was a problem hiding this comment.
Can we also add a comment/description on top of this method?
|
|
||
| // update the module's pinned version to be 1.0.0 | ||
| // NOTE: This is done here as an update instead of at create time, because | ||
| // that results in the following error: |
There was a problem hiding this comment.
Is that behavior expected?
There was a problem hiding this comment.
I am unsure - I am new to using that API endpoint; however, it seems like it should work with the version # provided.
paladin-devops
changed the title
paladin-devops
changed the title
uturunku1
previously approved these changes
Jul 26, 2024
uturunku1
approved these changes
Jul 26, 2024
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a method to the no-code registry modules resource for upgrading a no-code workspace.
Testing plan
Run
go test -run TestRegistryNoCodeModuleWorkspaceUpgrade -v ./...with the necessary environment variables.