fixing nil check for validString check

[veverkap]

So, o.PrivateKey references a memory address it seems, not a string value so it's never nil.

[alisdair]

Can we add test coverage for this?

[veverkap]

Can we add test coverage for this?

So, um, there WAS test coverage but it didn't work.

go-tfe/oauth_client_test.go

Lines 285 to 309 in 4b1fc6f

	t.Run("with private key and not ado_server options", func(t *testing.T) {
	options := OAuthClientCreateOptions{
	APIURL: String("https://api.github.com"),
	HTTPURL: String("https://github.com"),
	OAuthToken: String("NOTHING"),
	ServiceProvider: ServiceProvider(ServiceProviderGithub),
	PrivateKey: String("NOTHING"),
	}
	err := options.valid()
	assert.EqualError(t, err, "Private Key can only be present with Azure DevOps Server service provider")
	})
	t.Run("with valid options including private key", func(t *testing.T) {
	options := OAuthClientCreateOptions{
	APIURL: String("https://ado.example.com"),
	HTTPURL: String("https://ado.example.com"),
	OAuthToken: String("NOTHING"),
	ServiceProvider: ServiceProvider(ServiceProviderAzureDevOpsServer),
	PrivateKey: String("NOTHING"),
	}
	err := options.valid()
	assert.Nil(t, err)
	})

It's possible I'm doing it wrong.

[veverkap]

Can we add test coverage for this?

I added in a better test per your suggestion @alisdair