-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install failure with content-type mismatch #56
Comments
Hi @ryanwholey |
@radeksimko thank you, much appreciated! |
#57 merged and released as part of I have also notified the team maintaining https://github.com/hashicorp/terraform-plugin-sdk internally - which is used by most of |
[Plugin] Fix issue with `Content-Type` Summary of the Pull Request Fix issue with Content-Type PR Checklist Refers to: (hashicorp/hc-install#56) Reviewed-by: Vladimir Vshivkov <None> Reviewed-by: Anton Sidelnikov <None>
We are receiving
unexpected Content-Type: "application/vnd+hashicorp.releases-api.v0+json
when trying to download Terraform.Here is a small reproduction example:
This can be traced back to
hc-install/internal/releasesjson/releases.go
Lines 81 to 84 in af09eee
Perhaps the registry API now returns
application/vnd+hashicorp.releases-api.v0+json
instead ofapplication/json
? As a fix, would you be open to getting rid of checking the response header all together? Alternatively we could check both, but since we are handling JSON marshalling errors below, seems like maybe we can just dump this check all together.The text was updated successfully, but these errors were encountered: