Backport of mock_driver: fix fingreprint key into release/1.6.x #20404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-fix-mock-driver-fp/grossly-allowed-coyote
branch
from
3376765
to
3689c15
Compare
jrasell
approved these changes
Apr 16, 2024
jrasell
deleted the
backport/b-fix-mock-driver-fp/grossly-allowed-coyote
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20351 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
The below text is copied from the body of the original PR.
The
mock_driveris an internal task driver used mostly for testing and simulating workloads. During the allocrunner v2 work (#4792) its name changed frommock_driverto justmockand then back tomock_driver, but the fingreprint key was kept asdriver.mock.This results in tasks configured with
driver = "mock"to be scheduled (because Nomad thinks the client has a task driver calledmock), but fail to actually run (because the Nomad client can't find a driver calledmockin its catalog).Fingerprinting the right name prevents the job from being scheduled in the first place.
Also removes mentions of the mock driver from documentation since its an internal driver and not available in any production release.
No changelog since this is an internal change.
Overview of commits