Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numa: fix scheduler panic due to topology serialization bug #23284

Merged
merged 1 commit into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. numa: fix scheduler panic due to topology serialization bug

    The NUMA topology struct field `NodeIDs` is a `idset.Set`, which has no public
    members. As a result, this field is never serialized via msgpack and persisted
    in state. When `numa.affinity = "prefer"`, the scheduler dereferences this nil
    field and panics the scheduler worker.
    
    Ideally we would fix this by adding a msgpack serialization extension, but
    because the field already exists and is just always empty, this breaks RPC wire
    compatibility across upgrades. Instead, create a new field that's populated at
    the same time we populate the more useful `idset.Set`, and repopulate the set on
    demand.
    
    Fixes: https://hashicorp.atlassian.net/browse/NET-9924
    tgross committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ea5dd24 View commit details
    Browse the repository at this point in the history