Completeness changes / generation preparation for DevCenter
#3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat when a field is just called `uri` it gets updated to `service_uri`
…o conditionally handle `Uri` Whilst `ServiceUri` does make sense from a consistency standpoint, other resources within the same Service package can use the untrimmed name - as such when the trimmed field name is `Uri` for now let's just use the original name
…than an Integer for the name There's a length limit on the API
…ould be output without `*` The Identity types are always non-nil in the Typed Model and as such need to be dereferenced when optional
…hanges are released
stephybun
approved these changes
Oct 12, 2023
tools/importer-rest-api-specs/components/parser/dataworkarounds/workaround_devcenter_26189.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues related to the
DevCenterService, notably:DevCenter- scaffolding the Service Package to enable generation terraform-provider-azurerm#23530 has been mergedimporter-rest-api-specsfor Dev Center being a dependencydevCenterUrishould be a read only field Azure/azure-rest-api-specs#26189generator-terraformwhere Optional SystemAndUserAssignedMap identities wouldn't get assigned correctlyimporter-rest-api-specswhere a field name would be solely truncated toUri- and whilst I investigated making thisServiceUriconflicting input from other packages means when this is truncated to justUri, we should use the original name.DevCenterIDfield required for theDev Center Projectresource to workaround an API design issue where theDevCenterIDis defaulted/implied - meaning that the resource could be created with the wrongDevCenterID- making this Required solves this issue.