r/internet_gateway: Retry properly on DependencyViolation #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-aws-igw-detach-fix
branch
from
8f49b06
to
8d96490
Compare
|
@radeksimko Thanks a lot for this PR, that's great! I will include it in our CI pipeline and recheck if we get rid of that flake. |
|
/cc @jasminSPC @alexsomesan @Quentin-M |
s-urbaniak
pushed a commit
to s-urbaniak/tectonic-installer
that referenced
this pull request
Jun 30, 2017
This was referenced Jul 2, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Root cause of the bug is described in #945 (comment)
In addition to retrying I also added some extra debugging info which should help us in case this problem reoccurs - at least we'll know what ENIs are lying around and what/who created them.
I can confirm through my repro case + debug logs provided by @s-urbaniak that ELB (public one) is one service which can leave IPs around for a while and cause this error, but @s-urbaniak also mentioned that NAT Gateway can be blamed in coreos/tectonic-installer#1017 (comment) so this is possibly wide-spread problem throughout AWS services which allocate public IPs.
btw. We previously ignored unknown errors before, so I'm fixing that too in this PR.