chore: deprecate application_credential_source_ids #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisruch
force-pushed
the
louis-creds
branch
from
8c3f4d3
to
62cbda0
Compare
louisruch
force-pushed
the
louis-creds
branch
from
62cbda0
to
deca642
Compare
louisruch
requested review from
ddebko,
jefferai and
johanbrandhorst
and removed request for
jefferai
johanbrandhorst
approved these changes
Sep 7, 2022
| Type: schema.TypeSet, | ||
| Optional: true, | ||
| Deprecated: "Please use 'brokered_credential_source_ids' instead", | ||
| ConflictsWith: []string{targetBrokeredCredentialSourceIdsKey}, |
There was a problem hiding this comment.
Does this conflict not apply the other way too?
There was a problem hiding this comment.
It absolutely does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.