Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vault Credential Library Mapping Overrides #287

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

ddebko
Copy link
Contributor

@ddebko ddebko commented Oct 12, 2022

Summary:

  • support using username_attribute & password_attribute for vault credential library that is a username_password credential type
  • support using username_attribute, private_key_attribute & private_key_passphrase_attribute for vault credential library that is a ssh_private_key credential type

Open Questions:

when using the cli to remove an existing mapping override from a vault credential, you need to set the attribute value to null. Example:

boundary credential-libraries update vault \
    -id clvlt_WC6cZR7gKG \
    -credential-mapping-override "username_attribute=null" \
    -credential-mapping-override "password_attribute=null"

I thought that it might be weird to set an attribute value to null in the terraform resource. I think people would naturally try to just remove the resource credential_mapping_overrides or an attribute within the map. So I added logic on the update function to handle setting a removed value from the state file to nil for the user.

Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks!

@ddebko ddebko merged commit 807db1b into main Oct 13, 2022
@ddebko ddebko deleted the ddebko-override-mapping branch October 13, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants