Add support for boundary_self_managed_worker resource. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Nov 2, 2022
louisruch
requested changes
Nov 4, 2022
There was a problem hiding this comment.
Thanks for jumping on this and great work so far, I left a couple of comments inline. Also please do run make docs or go generate to auto generate to documentation. It would be great if you could also add an example config under examples
Accept suggested schema changes for tags Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
grantorchard
requested review from
johanbrandhorst
and removed request for
ddebko
johanbrandhorst
requested changes
Nov 10, 2022
|
All changes are in, I think we are good to go. |
johanbrandhorst
approved these changes
Nov 15, 2022
… 'boundary_worker' on resource checks
johanbrandhorst
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
LGTM but it'd be great to have @louisruch's thoughts as well. Could you also coordinate with @prsekar to create an issue for supporting tags later?
louisruch
approved these changes
Nov 16, 2022
|
Reopening PR to see if we can trigger the CI job |
|
Not sure what's up with Circle but I successfully ran the tests locally so lets merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, initial cut of a self-managed worker resource.
A couple of things to note: