Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add egress and ingress worker filters #319

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

irenarindos
Copy link
Contributor

@irenarindos irenarindos commented Jan 25, 2023

No description provided.

Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for doing this.

internal/provider/resource_target_test.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@tmessi
Copy link
Member

tmessi commented Feb 8, 2023

And now due to the api package updating, you need a change for the vault library that I have in my PR #320

--- a/internal/provider/resource_credential_library_vault.go
+++ b/internal/provider/resource_credential_library_vault.go
@@ -15,6 +15,7 @@ import (

 const (
 	credentialStoreIdKey                           = "credential_store_id"
+	credentialLibraryVaultType                     = "vault-generic"
 	credentialLibraryVaultHttpMethodKey            = "http_method"
 	credentialLibraryVaultHttpRequestBodyKey       = "http_request_body"
 	credentialLibraryVaultPathKey                  = "path"
@@ -156,7 +157,7 @@ func resourceCredentialLibraryCreateVault(ctx context.Context, d *schema.Resourc
 	}

 	client := credentiallibraries.NewClient(md.client)
-	cr, err := client.Create(ctx, credentialStoreId, opts...)
+	cr, err := client.Create(ctx, credentialLibraryVaultType, credentialStoreId, opts...)
 	if err != nil {
 		return diag.Errorf("error creating credential library: %v", err)
 	}

@irenarindos irenarindos marked this pull request as ready for review February 9, 2023 13:40
@irenarindos irenarindos merged commit af1b810 into main Feb 9, 2023
@irenarindos irenarindos deleted the irindos-update-worker-filters branch February 9, 2023 13:40
grantorchard pushed a commit to grantorchard/terraform-provider-boundary that referenced this pull request Aug 28, 2023
* Add egress and ingress worker filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants