Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont allow password change via tf apply #70

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Conversation

louisruch
Copy link
Contributor

What does this PR do

Removes update path for account passwords during terraform apply

This means if a user makes a change to the default password in their .tf file, it will be applied to future users created, previously created users will keep their password.

resource "boundary_account" "users_acct" {
  for_each       = var.users
  name           = each.key
  description    = "User account for the person named ${each.key}"
  type           = "password"
  login_name     = lower(each.key)
  password       = "password"   <--------------- I.E. user changes this
  auth_method_id = boundary_auth_method.password.id
}

@louisruch
Copy link
Contributor Author

louisruch commented Jan 15, 2021

Fixes #71
@malnick @jefferai PTAL, I discussed this with @jefferai, for now, the best solution seems to be disabling password updates via TF, if we want to allow users to store passwords in TF in the future and are happy with any security risks that imposes we can circle back. For now, this allows terraform apply to not error out

@louisruch
Copy link
Contributor Author

ping @malnick and/or @jefferai

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending wordsmithing.

@louisruch louisruch merged commit d94cd5a into main Jan 20, 2021
@louisruch louisruch deleted the ICU-941-password-change branch January 20, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants