Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server certificate validation with Root CA and insecure option #29

Closed

Conversation

barryib
Copy link

@barryib barryib commented Jan 2, 2020

This PR will let user validate TLS certificate with a provided root CA or choose a insecure option with no validation at all.

May solves hashicorp/terraform-provider-aws#11426 and have a lot of common usage.

Link for tests terraform-aws-modules/terraform-aws-eks#1339

@barryib barryib changed the title Add CA certificate verification and insecure option Add server certificate validation with Root CA and insecure option Jan 3, 2020
@techdragon
Copy link

techdragon commented May 5, 2020

This would be an extremely helpful addition given the number of missing data objects in a number of the providers. (Most notably the Kubernetes provider which lacks data equivalents to almost every resource it can make) At the moment in order to work around missing Kubernetes data sources (In order to query things created with the helm provider) I have to work around the lack of TLS support by using the shell provider and using curl directly.

@barryib barryib force-pushed the tba-add-server-cert-verification branch from 84ab348 to 18aae20 Compare May 21, 2020 00:06
@ghost ghost added size/L and removed size/S labels May 21, 2020
@barryib
Copy link
Author

barryib commented May 21, 2020

Any chance to see this PR reviewed or at least close it if it doesn't make sense here ?

@barryib barryib force-pushed the tba-add-server-cert-verification branch from 79f3790 to d3c1418 Compare May 21, 2020 19:43
@jonatan-b-kr
Copy link

Is there any current workaround while we wait for this to get merged?

@techdragon
Copy link

@jonatan-b-kr I had to use the shell provider and curl in order to get around this. Its not a very good workaround because of the limitations of the shell provider.

@barryib barryib force-pushed the tba-add-server-cert-verification branch from d3c1418 to cc46692 Compare October 5, 2020 16:46
@barryib
Copy link
Author

barryib commented Oct 5, 2020

It's almost 10 months now since this PR is open without any comment from the maintainer. Is this something we want to merge in ? If yes, how can the PR be review ? If not, please tell me so I close this PR and move on another solution.

@barryib
Copy link
Author

barryib commented Oct 5, 2020

Maybe @apparentlymart could help ?

@barryib
Copy link
Author

barryib commented Oct 6, 2020

It's almost 10 months now since this PR is open without any comment from the maintainer. Is this something we want to merge in ? If yes, how can the PR be review ? If not, please tell me so I close this PR and move on another solution.

@paultyng please advise.

Base automatically changed from master to main February 1, 2021 17:28
@barryib barryib force-pushed the tba-add-server-cert-verification branch 2 times, most recently from 9c932c6 to 0a84c06 Compare May 4, 2021 21:51
@barryib
Copy link
Author

barryib commented May 4, 2021

@kmoe any chance to review this PR ?

@barryib
Copy link
Author

barryib commented May 6, 2021

Maybe @aareet or @bflad can review this ? I just want to know if this something hashicorp wants to add in this provider or not.

@stevehipwell
Copy link

This would be really useful if it could be merged?

@daroga0002
Copy link

@aareet or @bflad is there chance to review this?

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Thierno BARRY seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@sbuzonas
Copy link

@barryib perhaps this is still pending awaiting contribution attribution for the CLA

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants