Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Add mysql_user importer #113

Closed

Conversation

winebarrel
Copy link

Add importer for mysql_user resource.

terraform import mysql_user.jdoe jdoe@localhost

@ghost ghost added the size/S label Feb 20, 2020
@morganchristiansson
Copy link

Yesss! Please add terraform import mysql_user

@washingtoneg
Copy link

@davidji99, would you be able to review this? My apologies for the direct ping; my organization needs this and I would love to see this merged in upstream.

@davidji99
Copy link
Contributor

davidji99 commented May 15, 2020

Hi @washingtoneg,

Sure thing! No worries.

Two things on this PR for @winebarrel:

  • Please update the documentation for this resource to reflect the newly added import functionality.
  • Please provide an import test. You can refer to any import_* file in the Heroku provider for guidance. Once you have done so, paste the console output for a test run. I'll need to spend a bit of time to wire up Github Actions for CI.

Other than that, looks good.

@llomgui
Copy link

llomgui commented Jun 9, 2020

Hello,

Can you provide an update on this PR?
@winebarrel Do you need help with the documentation and tests?

@davidji99 davidji99 mentioned this pull request Jul 16, 2020
@winebarrel winebarrel closed this Jul 16, 2020
@winebarrel winebarrel deleted the add_mysql_user_importer branch May 6, 2021 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants