Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.16 for darwin/arm64 architecture support #288

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Use Go 1.16 for darwin/arm64 architecture support #288

merged 3 commits into from
Mar 31, 2021

Conversation

chrisarcand
Copy link
Member

Description

Go 1.16 introduces support for Apple Silicon. These changes make Go 1.16 the default for local development and CI purposes.

Replaces #280

Testing plan

Everything should build and run cleanly from the standard Make targets.

Output from acceptance tests

$ /usr/bin/make -f /Users/jamesthompson/Projects/terraform-provider-tfe/GNUmakefile testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]

@chrisarcand chrisarcand requested a review from a team March 30, 2021 17:25
@chrisarcand chrisarcand mentioned this pull request Mar 30, 2021
Closed
radditude
radditude previously approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@radditude radditude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one more spot where a number needs to be updated:

terraform-provider-tfe/README.md

Line 85 in 5a80a5a

Building the provider requires [Go](https://golang.org/doc/install) >= 1.14

omarismail
omarismail previously approved these changes Mar 30, 2021
View reviewed changes
@chrisarcand chrisarcand dismissed stale reviews from omarismail and radditude via 9502e9c March 30, 2021 20:08
@chrisarcand chrisarcand merged commit acf7e60 into master Mar 31, 2021
@chrisarcand chrisarcand deleted the use-go-1-16 branch March 31, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarismail omarismail omarismail approved these changes

@radditude radditude radditude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisarcand @omarismail @radditude @plainprogrammer