Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat workspace deletion api errors as errors #758

Closed
wants to merge 1 commit into from
Closed

fix: treat workspace deletion api errors as errors #758

wants to merge 1 commit into from

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Jan 9, 2023

Description

#675 (comment)

@skeggse skeggse requested a review from a team as a code owner January 9, 2023 22:47
sebasslash
sebasslash approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, thanks for catching this. I will rebase your changes onto a local branch so we can run it against CI 👍

@sebasslash
Copy link
Contributor

See #759

@skeggse
Copy link
Contributor Author

skeggse commented Jan 9, 2023 •
edited
Loading

Thank you!

@skeggse
Copy link
Contributor Author

skeggse commented Jan 9, 2023

Duplicate of #759.

@skeggse skeggse closed this Jan 9, 2023
@skeggse skeggse deleted the patch-3 branch January 9, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasslash sebasslash sebasslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skeggse @sebasslash