r/tfe_workspace_run: Ensure wait_for_run=false results in a fire-and-forget Run

[lucymhdavies]

Description

Fix for #908

Remember to:

• Update the Change Log
• Update the Documentation

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspaceRun" make testacc
TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEWorkspaceRun -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]
=== RUN   TestAccTFEWorkspaceRunTaskDataSource_basic
    testing.go:232: Skipping tests for Run Tasks. Set 'RUN_TASKS_URL' to enabled this tests.
--- SKIP: TestAccTFEWorkspaceRunTaskDataSource_basic (0.00s)
=== RUN   TestAccTFEWorkspaceRunTask_create
    testing.go:232: Skipping tests for Run Tasks. Set 'RUN_TASKS_URL' to enabled this tests.
--- SKIP: TestAccTFEWorkspaceRunTask_create (0.00s)
=== RUN   TestAccTFEWorkspaceRunTask_beta_create
    testing.go:232: Skipping tests for Run Tasks. Set 'RUN_TASKS_URL' to enabled this tests.
--- SKIP: TestAccTFEWorkspaceRunTask_beta_create (0.00s)
=== RUN   TestAccTFEWorkspaceRunTask_import
    testing.go:232: Skipping tests for Run Tasks. Set 'RUN_TASKS_URL' to enabled this tests.
--- SKIP: TestAccTFEWorkspaceRunTask_import (0.00s)
=== RUN   TestAccTFEWorkspaceRun_withApplyOnlyBlock
2023/05/30 12:09:55 [DEBUG] Configuring client for host "app.terraform.io"
2023/05/30 12:09:55 [DEBUG] Service discovery for app.terraform.io at https://app.terraform.io/.well-known/terraform.json
2023/05/30 12:09:56 [DEBUG] Attempting to fetch token from Terraform CLI configuration for hostname app.terraform.io...
    testing.go:89: failed to enumerate feature sets: resource not found
--- FAIL: TestAccTFEWorkspaceRun_withApplyOnlyBlock (0.92s)
=== RUN   TestAccTFEWorkspaceRun_withBothApplyAndDestroyBlocks
2023/05/30 12:09:56 [DEBUG] Configuring client for host "app.terraform.io"
2023/05/30 12:09:56 [DEBUG] Service discovery for app.terraform.io at https://app.terraform.io/.well-known/terraform.json
2023/05/30 12:09:57 [DEBUG] Attempting to fetch token from Terraform CLI configuration for hostname app.terraform.io...
    testing.go:89: failed to enumerate feature sets: resource not found
--- FAIL: TestAccTFEWorkspaceRun_withBothApplyAndDestroyBlocks (0.84s)
=== RUN   TestAccTFEWorkspaceRun_invalidParams
2023/05/30 12:09:57 [DEBUG] Configuring client for host "app.terraform.io"
2023/05/30 12:09:57 [DEBUG] Service discovery for app.terraform.io at https://app.terraform.io/.well-known/terraform.json
2023/05/30 12:09:57 [DEBUG] Attempting to fetch token from Terraform CLI configuration for hostname app.terraform.io...
    testing.go:89: failed to enumerate feature sets: resource not found
--- FAIL: TestAccTFEWorkspaceRun_invalidParams (0.86s)
=== RUN   TestAccTFEWorkspaceRun_WhenRunErrors
2023/05/30 12:09:58 [DEBUG] Configuring client for host "app.terraform.io"
2023/05/30 12:09:58 [DEBUG] Service discovery for app.terraform.io at https://app.terraform.io/.well-known/terraform.json
2023/05/30 12:09:58 [DEBUG] Attempting to fetch token from Terraform CLI configuration for hostname app.terraform.io...
    testing.go:89: failed to enumerate feature sets: resource not found
--- FAIL: TestAccTFEWorkspaceRun_WhenRunErrors (0.87s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-tfe/tfe	3.908s
FAIL
make: *** [testacc] Error 1

Which... I'm not sure if that's a problem with me running the tests, or if this is the tests failing because the functionality has changed. It seems like the former (some issue running the tests)

Tests are failing in GitHub Actions because this PR comes from my fork of the provider, and I believe we need to do some special additional steps to get that working.
(I don't have permissions on the repo myself to do that, hence the fork)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1204701259942736

[brandonc]

@lucymhdavies I added hashicorp/team-se to collaborate on this repo. Can you push this branch directly to the repo in order to get access to CI?

[lucymhdavies]

Closing in favor of #917