Add an option to skip certificate verifications #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Can we get PR reviewed? |
|
@beekus Could we get some 👀 on this one? |
Terraform's discovery client uses its own HTTP client transport that we do not control. In order for "disco" to skip TLS validation we change the transport to the one the TFE client uses.
koikonom
force-pushed
the
svh/f-ssl-skip-verify
branch
from
5091d12
to
4b38b3d
Compare
|
Since this was a pretty old PR I rebased it on top of master which is why I had to force push. |
lafentres
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #82, but as I don't have a pTFE install to test against it would be great if this can be tested by someone from support before merging this one.