providers/aws: reduce scope of block_device set hashcodes #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1409 Resource set hash calculation is a bit of a devil's bargain when it comes to optional, computed attributes. If you omit the optional, computed attribute from the hash function, changing it in an existing config is not properly detected. If you include the optional, computed attribute in the hash and do not specify a value for it in the config, then you'll end up with a perpetual, unresolvable diff. We'll need to think about how to get the best of both worlds, here, but for now I'm switching us to the latter and documenting the fact that changing these attributes requires manual `terraform taint` to apply.
|
LGTM |
phinze
added a commit
that referenced
this pull request
Apr 9, 2015
…out-both-volume-fields providers/aws: reduce scope of block_device set hashcodes
displague
added a commit
to displague/deprecated-terraform-provider-linode
that referenced
this pull request
Jul 25, 2018
…ode_id causes problems hashicorp/terraform#1445
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409
Resource set hash calculation is a bit of a devil's bargain when it
comes to optional, computed attributes.
If you omit the optional, computed attribute from the hash function,
changing it in an existing config is not properly detected.
If you include the optional, computed attribute in the hash and do not
specify a value for it in the config, then you'll end up with a
perpetual, unresolvable diff.
We'll need to think about how to get the best of both worlds, here, but
for now I'm switching us to the latter and documenting the fact that
changing these attributes requires manual
terraform taintto apply.