Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet bare metal cloud hosting platform provider #2260

Merged
merged 1 commit into from
Oct 7, 2015
Merged

Packet bare metal cloud hosting platform provider #2260

merged 1 commit into from
Oct 7, 2015

Conversation

crunchywelch
Copy link

First effort on this, let me know if you'd like to have tests written or if this is a good place to start with the initial PR. Thanks!

)

const (
consumerToken = "aZ9GmqHTPtxevvFq9SK3Pi2yr9YCbRzduCSXF2SNem5sjB91mDq7Th3ZwTtRqMWZ"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used by us to identify the source of a request, this is the one we issued for terraform. basically, it is not required, but if it is not present then we rate limit the requests. it is also not used for authentication, that is what the end user's auth token is used for. does that make sense?

@crunchywelch
Copy link
Author

Also, I have a test for the device resource, but it requires a project id, and I'm not sure the best way to inject that into the config variables. If someone can point me to an example I'll drop that in as well, otherwise will take a deeper look later this week.

@rimusz
Copy link

rimusz commented Jul 13, 2015

@radeksimko would be nice to get it merged to master, so it can be released with the next terraform version.
Packet.net offers very nice bare-metal servers service, and to have it's support in terraform would make much easier to deploy it's servers.

@josephholsten
Copy link
Contributor

@phinze looks ready for 👀, has tests & doc too!


log.Printf("[INFO] Device ID: %s", d.Id())

_, err = WaitForDeviceAttribute(d, "active", []string{"provisioning"}, "state", meta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crunchywelch Should you perhaps add "queued" to the pending states?

@phinze
Copy link
Contributor

phinze commented Oct 7, 2015

This is looking good! I'll pull it in as-is and improvements can be made on separate PRs.

Also, I have a test for the device resource, but it requires a project id, and I'm not sure the best way to inject that into the config variables. If someone can point me to an example I'll drop that in as well, otherwise will take a deeper look later this week.

@crunchywelch generally for tests that require special settings like that we just have test-specific environment variables and skip the test with a message if they're not set.

phinze added a commit that referenced this pull request Oct 7, 2015
Packet bare metal cloud hosting platform provider
@phinze phinze merged commit 40f09b7 into hashicorp:master Oct 7, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants